jX<
d Z ddlmZ ddlmZ ddlmZ ddlZddlZddlZddlm Z ddl
m Z m Z m
Z
mZ ddlmZmZ dd lmZ dd
l
mZ dd lmZ d Zd
ZdZdZ eddh Z dZ d Z d Z d Z d dZ!d Z"d Z#d Z$d Z%d Z&d Z'dS ) u
clsudoers unix group management for lvemanager.
Operator upgrade note (CLOS-4576, F-37): ``add_unix_user_to_sudoers()`` now
fails closed when the ``clsudoers`` unix group has pre-existing members
outside the legitimate set (``admins()`` + the user being added +
package-owned runtime users vetted by ``_is_system_owned_user``).
Previously, ``groupadd -f`` was silently idempotent and any stowaway
primary-GID owners or ``gr_mem`` entries (left by manual admin steps or
another RPM's post-install) were quietly elevated to passwordless sudo
for selectorctl / cloudlinux-selector.
Package-owned runtime users (``root``; the lvemanager RPM's ``lvemanager``
system user; DA-side ``lvemanager_`` variants) are exempted via
``_is_system_owned_user``, which requires the name to belong to the
lvemanager package family AND the account's UID to fall in the
system-UID range (< 1000). CLOS-5544 (F-30) closes the earlier
regression where those names were seeded directly into the expected
set and thereby short-circuited the UID check — a regular-UID account
sharing a package-owned name (e.g. a legacy ``lvemanager`` UID 5000)
would otherwise slip through the gate.
After upgrading to a build that ships this change, the first admin-add
operation on an AFFECTED host (one with non-package stowaways in the
group) raises an exception from ``_assert_sudoers_group_clean()``. To
recover, operators must either:
* remove the stowaway entries from the ``clsudoers`` group (audit with
``getent group clsudoers`` and ``awk -F: '$4== {print $1}' /etc/passwd``
for primary-GID owners), OR
* add those users via the panel's ``admins()`` interface (panel admin user
list) so they are recognised as legitimate members before retrying.
This is intentional — silent elevation of unaudited accounts is the
vulnerability being closed; reverting to ``groupadd -f`` idempotence is not
an acceptable workaround.
)print_function)division)absolute_importN) remount_proc)adminscpusers getCPName is_reseller)
SysCtlConfSYSCTL_CL_CONF_FILE)Feature)is_panel_feature_supported)Clsudoadmin
clsupergid clsudoersi root
lvemanager) lvemanager_c dk rdS t v p t fdt D }|sdS t j j t k S # t $ r Y dS w xY w)u Return True if `name` is a known package-owned `clsudoers` member
(always-allowed name OR an lvemanager-package-family name) AND lives
in the system-UID range. Both conditions are required — a regular
user named `lvemanager_evil` (UID 5000) is NOT package-owned; an
unrelated system account named `daemon` (UID 2) is NOT package-owned
either. The gate exists to fire on the F-37 priv_group_reuse
signature; we only want to exempt the RPM's own post-install state.
r Tc 3 B K | ]} | V d S N)
startswith).0pnames I/opt/cloudlinux/venv/lib64/python3.11/site-packages/lvemanager/sudoers.py z(_is_system_owned_user..d s/ O O1DOOA O O O O O O F) _PACKAGE_OWNED_CLSUDOERS_MEMBERSany&_PACKAGE_OWNED_CLSUDOERS_NAME_PREFIXESpwdgetpwnampw_uid_SYSTEM_UID_MAXKeyError)r
is_known_names ` r _is_system_owned_userr) V s v~~t 00 P O O O O(N O O OOO u|D!!(O;; uus !A
A('A(c F t j dd| |g }|dk rdS dS )z Add user to given unix group/usr/bin/gpasswdz-ar FT
subprocesscall user_name
group_nameretcodes r _add_user_to_groupr3 p s. o 14J OPPG!||u 4r c F t j dd| |g }|dk rdS dS )Nr+ z-dr FTr, r/ s r _remove_user_from_groupr5 y s. o 14J OPPG!||u 4r c , t j | j }n# t $ r Y dS w xY w|sdS t t }t t
}n-# t $ r }t d| d| Y d}~dS d}~ww xY w|st d| z dS t | |z }|D ]S}||v s||vr t | r n# t $ r Y )w xY wt d|d| d t || TdS )a6
Remove panel end-users (tenants) from a privileged group.
CLOS-4594 (F-54/F-56): membership of the fs.proc_super_gid group (clsupergid) is
privileged and must be limited to legitimate elevated actors. lve-utils
(clsupergid_process / clsetuplib) may reuse a pre-existing group of that name, so we
reconcile its membership here. lve-utils cannot tell a legitimate panel admin
(a regular uid >= UID_MIN login) from a tenant; lvemanager can, because it knows the
authoritative cpapi sets. Here we remove only CONFIRMED panel end-users
(cpapi.cpusers() that are neither admins nor resellers) -- a tenant must never be a
member. This deliberately does NOT use a uid threshold (which is what made the
earlier in-tool attempt false-abort on real cPanel/DA/Plesk hosts by flagging legitimate
panel admins as untrusted).
Fail-safe rules (must never strip a legitimate elevated actor):
* If cpapi enumeration raises, OR admins() returns an EMPTY set, do nothing and return.
An empty admin set cannot be distinguished from a failed-open read (e.g. DirectAdmin
admins() returns set() without raising when admin.list is empty/truncated mid-write,
while DA admins are simultaneously listed by cpusers()); reconciling against it would
strip every real admin from the group -- the very regression this fix exists to avoid.
* Admins (admins()), the just-added admin (keep), and resellers (is_reseller()) are
elevated actors and are never removed. Service accounts (nagios/mailman/polkitd, the
lvemanager system user, ...) are not panel users, so they are never candidates.
:param group_name: the group to reconcile (the configured proc-super group)
:param keep: extra usernames to preserve regardless (e.g. the admin being added right now)
NzCWARNING: could not enumerate panel admins/users to validate group 'z': zSWARNING: admins() returned no admins; skipping tenant eviction for '%s' (fail-safe)z WARNING: removing panel user 'z' from privileged group 'z
' (CLOS-4594)) grpgetgrnamgr_memr' setr r Exceptionprintr
r5 )r1 keepmembers admin_set
tenant_setekeep_setmembers r _remove_tenants_from_grouprE s 8,z**1 MM ^^
QQ ! ! ! c 4yy9$H
4
4 X z!9!9 6""
H
% & & &
3333
4
4s5
**6A) )
B3BB C
C*)C*c t t }||vr| | |D ]}t || t | |f dS )z
Add all present DA admins (plus new_admin_name admin) to supplied group
:param new_admin_name: new admin name to add
:return:
)r> N)listr appendr3 rE )r1 new_admin_name
admin_listr s r _add_admins_into_grouprK sr fhh JZ''.))) . .5*---- z 0ABBBBBBr c D t j dd| g }|dk rdS dS )z Create group with given namez/usr/sbin/groupaddz-fr FTr, )r1 r2 s r
_create_grouprM s, o 3T: FGGG!||u 4r c t t j t j }t t }| d }| d s-| d| t t | dS t dk rr t t j t j }n# t $ r d}Y nw xY w||k r-| d| t t | dS t | }n # t $ r t! d w xY wt j | j }t || dS )z
Add all present DA admins (plus new_admin_name admin) to current supergid group
:param new_admin_name: new admin name to add
:return:
) config_filezfs.proc_super_gidN DirectAdminz6Bad fs.proc_super_gid option value in /etc/sysctl.conf)strr8 r9 SUPER_GROUP_NAMEgr_gidr r get
has_parameterr; rK r DEFAULT_GROUP_NAMEr' int
ValueError RuntimeErrorgetgrgidgr_name)rI super_gid
sysctl_cfgproc_super_gid admin_gidproc_super_names r _add_admins_into_supergid_grpra s CL!1229::I(;<<22:O?N;;;;;s ++C C&%C& D- -Ec t j | n# t $ r Y dS w xY wt | fdj D }fdt j D }|s|rt d| d|d| dS )a?
Refuse to grant %group_name passwordless sudo if the unix group already
exists with members or primary-GID owners that the lvemanager flow did
not place there. `groupadd -f` is silently idempotent and would otherwise
elevate any pre-existing member on the first call.
:param group_name: target group (clsudoers)
:param expected_members: iterable of usernames the lvemanager flow is
about to authorize (panel admins + the user being added).
:raises Exception: if any unexpected secondary member or primary-GID
owner is found.
Nc : g | ]}|vt | |S r6 )r) )r mexpecteds r
z/_assert_sudoers_group_clean.. s< H %:1%=%=
r c x g | ]6}|j j k r$|j vt |j /|j 7S r6 )pw_gidrS pw_namer) )r r re grs r rf z/_assert_sudoers_group_clean.." sS 8ry
IX % %%ai00
&
% % %r zERROR: refusing to grant %z9 passwordless sudo: group already has unexpected members z and primary-GID owners )r8 r9 r' r; r: r# getpwallr< )r1 expected_membersunexpected_membersunexpected_primaryre rj s @@r _assert_sudoers_group_cleanro s
\*
%
% #$$H 9 <>> E / Ei
. . .0B0B
DE E EE Es
''c t t j rjt t st dt z t
| t | t st d| dt d t t }|
| t t | t t st dt z t | t st d| dt d t }| t t d S )Nz ERROR: Can't create %s group
zERROR: Can't add user z to z group
)r r
LVErM rR r< ra r3 r; r addro SUDOERS_GROUP_NAMEr add_lvemanager_groupr )r expected_clsudoerssudos r add_unix_user_to_sudoersrw / sO !'+.. ) -.. Q r s $ $L & % % % % % & & & & & &
( ( ( ( ( ( B B B B B B B B B B B B ; ; ; ; ; ; ; ; " " " " " " 5 5 5 5 5 5 ! $-9fl-C#D#D )9 & 4 :4 :4 :4 :4zC C C" $< $< $